[
https://issues.apache.org/jira/browse/YARN-8927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768482#comment-16768482
]
Eric Badger commented on YARN-8927:
-----------------------------------
{quote}
Chandni Singh is solving the docker image localization issues in YARN-9228. It
may help to solve precheck of image existence in her story instead.
{quote}
I'm fine with moving this to another JIRA. I just don't want to preclude an
environment where only local images are allowed. And doing the determination of
whether an image is local or not based on the existence of a "/" character
doesn't do that, since local images are perfectly allowed to contain the "/"
character in their tag.
I don't want to hold up this feature either, however. So maybe it's best to
diverge into 2 different paths here. Keep this JIRA alive to deal only with the
library keyword and have the library keyword only associated with dockerhub
images. Then in another JIRA add a different keyword for local images. Because
using the library keyword for local images in this state would not work out. I
really don't like the idea of another keyword, since I hate making arbitrary
special keywords, but I don't see another way around the issue here.
> Support trust top-level image like "centos" when "library" is configured in
> "docker.trusted.registries"
> -------------------------------------------------------------------------------------------------------
>
> Key: YARN-8927
> URL: https://issues.apache.org/jira/browse/YARN-8927
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Zhankun Tang
> Assignee: Zhankun Tang
> Priority: Major
> Labels: Docker
> Attachments: YARN-8927-trunk.001.patch, YARN-8927-trunk.002.patch
>
>
> There are some missing cases that we need to catch when handling
> "docker.trusted.registries".
> The container-executor.cfg configuration is as follows:
> {code:java}
> docker.trusted.registries=tangzhankun,ubuntu,centos{code}
> It works if run DistrubutedShell with "tangzhankun/tensorflow"
> {code:java}
> "yarn ... -shell_env YARN_CONTAINER_RUNTIME_TYPE=docker -shell_env
> YARN_CONTAINER_RUNTIME_DOCKER_IMAGE=tangzhankun/tensorflow
> {code}
> But run a DistrubutedShell job with "centos", "centos[:tagName]", "ubuntu"
> and "ubuntu[:tagName]" fails:
> The error message is like:
> {code:java}
> "image: centos is not trusted"
> {code}
> We need better handling the above cases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
