[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771230#comment-16771230
]
Szilard Nemeth commented on YARN-9267:
--------------------------------------
Hi [~pbacsko]!
Thanks for this patch!
Looks good, except some minor things:
1. FpgaDevice.hash should include in its name somehow that this is the hash of
the aocx file.
2. I would move the method FpgaResourceHandlerImpl#getSha256 to some more
common place, this seems to be a helper function that could be used elsewhere.
3. I would also modify the error message (LOG.error("Could not calculate
SHA-256", e);) of getSha256 to better indicate what exactyly went wrong.
Thanks!
> Various fixes are needed in FpgaResourceHandlerImpl
> ---------------------------------------------------
>
> Key: YARN-9267
> URL: https://issues.apache.org/jira/browse/YARN-9267
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: YARN-9267-001.patch, YARN-9267-002.patch
>
>
> Fix some problems in {{FpgaResourceHandlerImpl}}:
> * {{preStart()}} does not reconfigure card with the same IP - we see it as a
> problem. If you recompile the FPGA application, you must rename the aocx file
> because the card will not be reprogrammed. Suggestion: instead of storing
> Node<\->IPID mapping, store Node<\->IPID hash (like the SHA-256 of the
> localized file).
> * Switch to slf4j from Apache Commons Logging
> * Some unused imports
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
