[ 
https://issues.apache.org/jira/browse/YARN-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792985#comment-13792985
 ] 

Sandy Ryza commented on YARN-1300:
----------------------------------

Thanks for the patch.  If we're going to be moving the allocations properties 
to fair-scheduler.xml, we should be deleting fair-scheduler-allocations.xml, 
right?  Also, because fair-scheduler.xml is in src/test/resources, it should 
end up on the classpath, so should be able to take out
{code}

  <property>
    <description>Absolute path to allocation file. An allocation file is an XML
    manifest describing queues and their properties, in addition to certain
    policy defaults. This file must be in XML format as described in
    
http://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/FairScheduler.html.
    </description>
    <name>yarn.scheduler.fair.allocation.file</name>
    <value>src/test/resources/fair-scheduler-allocation.xml</value>
  </property>
{code}

> SLS tests fail because conf puts yarn properties in fair-scheduler.xml
> ----------------------------------------------------------------------
>
>                 Key: YARN-1300
>                 URL: https://issues.apache.org/jira/browse/YARN-1300
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: yarn-1300-v1.patch, yarn-1300-v2.patch
>
>
> I was looking at 
> https://builds.apache.org/job/PreCommit-YARN-Build/2165//testReport/org.apache.hadoop.yarn.sls/TestSLSRunner/testSimulatorRunning/
> I am able to reproduce the failure locally.
> I found that FairSchedulerConfiguration.getAllocationFile() doesn't read the 
> yarn.scheduler.fair.allocation.file config entry from fair-scheduler.xml
> This leads to the following:
> {code}
> Caused by: 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationConfigurationException:
>  Bad fair scheduler config file: top-level element not <allocations>
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.reloadAllocs(QueueManager.java:302)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.initialize(QueueManager.java:108)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler.reinitialize(FairScheduler.java:1145)
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to