[
https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775975#comment-16775975
]
Szilard Nemeth commented on YARN-9121:
--------------------------------------
Hi [~sunilg]!
Addressed the findbugs issue with the new patch, a synchronized modifier was
required on the GpuResourcePlugin#getNMResourceInfo method.
> Users of GpuDiscoverer.getInstance() are not possible to test as instance is
> a static field
> -------------------------------------------------------------------------------------------
>
> Key: YARN-9121
> URL: https://issues.apache.org/jira/browse/YARN-9121
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9121.001.patch, YARN-9121.002.patch,
> YARN-9121.003.patch
>
>
> The clients of GpuDiscoverer are very hard to test as they call
> GpuDiscoverer.getInstance() internally.
> For example, writing tests for
> org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu.GpuResourcePlugin#getNMResourceInfo
> is quite hard as the GpuDeviceInformation returned by GpuDiscoverer is not
> interchangeable as GpuDiscoverer is not mockable since we cannot inject it in
> tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
