[
https://issues.apache.org/jira/browse/YARN-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780695#comment-16780695
]
Eric Yang commented on YARN-9328:
---------------------------------
[~Prabhu Joseph], this is a log4j 1.x design limitation, see:
https://bz.apache.org/bugzilla/show_bug.cgi?id=57714 for background
information. I don't think moving the log and locking in the patch solves this
particular problem. The correct solution is to move to log4j 2.x or slf4j. I
had submitted a patch for log4j for this in
https://bz.apache.org/bugzilla/show_bug.cgi?id=41214, however, it was not
accepted as a solution because it uses newer JDK API to solve the problem which
prevents log4j 1.2 to be backward compatible with Java 1.5.
> ParentQueue#apply move log outside writelock
> --------------------------------------------
>
> Key: YARN-9328
> URL: https://issues.apache.org/jira/browse/YARN-9328
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Bibin A Chundatt
> Assignee: Prabhu Joseph
> Priority: Major
> Attachments: YARN-9328-001.patch, YARN-9328-002.patch
>
>
> {code}
> LOG.info("assignedContainer" + " queue=" + getQueueName()
> + " usedCapacity=" + getUsedCapacity() + "
> absoluteUsedCapacity="
> + getAbsoluteUsedCapacity() + " used=" + queueUsage.getUsed()
> + " cluster=" + cluster);
> {code}
> Logging can be done after log.. Logging could reduce performance ..
> {code}
> "Thread-16" #40 daemon prio=5 os_prio=0 tid=0x00007f181f9bb800 nid=0x125
> waiting for monitor entry [0x00007ef163bab000]
> java.lang.Thread.State: BLOCKED (on object monitor)
> at org.apache.log4j.Category.callAppenders(Category.java:204)
> - locked <0x00007ef2d803e2b8> (a org.apache.log4j.spi.RootLogger)
> at org.apache.log4j.Category.forcedLog(Category.java:391)
> at org.apache.log4j.Category.log(Category.java:856)
> at
> org.apache.commons.logging.impl.Log4JLogger.info(Log4JLogger.java:176)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.ParentQueue.apply(ParentQueue.java:1336)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue.apply(LeafQueue.java:1371)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp.apply(FiCaSchedulerApp.java:665)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.tryCommit(CapacityScheduler.java:2946)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler$ResourceCommitterService.run(CapacityScheduler.java:644)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
