[ https://issues.apache.org/jira/browse/YARN-9341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783062#comment-16783062 ]
Prabhu Joseph commented on YARN-9341: ------------------------------------- Reviewed below files which are using lock() in hadoop-yarn-project. {code} HW12663:hadoop-yarn-project pjoseph$ find . -name *.java | xargs grep -w "lock()" | wc -l 662 {code} > Reentrant lock() before try > --------------------------- > > Key: YARN-9341 > URL: https://issues.apache.org/jira/browse/YARN-9341 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn > Affects Versions: 3.1.0 > Reporter: Prabhu Joseph > Assignee: Prabhu Joseph > Priority: Minor > Attachments: YARN-9341-001.patch > > > As a best practice - Reentrant lock has to be acquired before try clause. > https://stackoverflow.com/questions/31058681/java-locking-structure-best-pattern > There are many places where lock is obtained inside try. > {code} > try { > this.writeLock.lock(); > .... > } finally { > this.writeLock.unlock(); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org