[
https://issues.apache.org/jira/browse/YARN-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785237#comment-16785237
]
Prabhu Joseph edited comment on YARN-9343 at 3/6/19 5:48 AM:
-------------------------------------------------------------
Hi [~wilfreds], Have included hadoop-yarn-server-common also in patch 2 which
moved to Slf4j after patch 1 - YARN-7243. Have reverted some file in patch 1
where the logging is expensive and better to keep the guard.
1. Used debug({}, ex) as a standard way.
2. Have left unchanged in places where the logging is expensive and guard is
present.
Will attach v3 patch fixing the new checkstyle issues. Test case failures are
not related and will be fixed by YARN-9338. Compilation failures are not
related and runs fine on local.
was (Author: prabhu joseph):
Hi [~wilfreds], Have included hadoop-yarn-server-common also in patch 2 which
moved to Slf4j after patch 1 - YARN-7243. Have reverted some file in patch 1
where the logging is expensive and better to keep the guard.
1. Used debug({}, ex) as a standard way.
2. Have left unchanged in places where the logging is expensive and guard is
present.
Will attach v3 patch fixing the new checkstyle issues.
> Replace isDebugEnabled with SLF4J parameterized log messages
> ------------------------------------------------------------
>
> Key: YARN-9343
> URL: https://issues.apache.org/jira/browse/YARN-9343
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Major
> Attachments: YARN-9343-001.patch, YARN-9343-002.patch,
> YARN-9343-003.patch
>
>
> Replace isDebugEnabled with SLF4J parameterized log messages.
> https://www.slf4j.org/faq.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
