[ 
https://issues.apache.org/jira/browse/YARN-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786336#comment-16786336
 ] 

Wilfred Spiegelenburg commented on YARN-9343:
---------------------------------------------

Thank you for the update [~Prabhu Joseph]

I can see that we still have 200+ {{LOG.isDebugEnabled()}} calls in the code. 
two things:
# There are a lot of simple one parameter calls which could easily be converted 
to unguarded calls, examples:
* NvidiaDockerV1CommandPlugin.java
* FSParentQueue.java
* Application.java
# Some of the calls to {{LOG.debug}} that are guarded inside those have not 
been changed to parameterised calls yet. Do you want to file a followup jira 
for that or should that also be part of these changes?

> Replace isDebugEnabled with SLF4J parameterized log messages
> ------------------------------------------------------------
>
>                 Key: YARN-9343
>                 URL: https://issues.apache.org/jira/browse/YARN-9343
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Prabhu Joseph
>            Assignee: Prabhu Joseph
>            Priority: Major
>         Attachments: YARN-9343-001.patch, YARN-9343-002.patch, 
> YARN-9343-003.patch
>
>
> Replace isDebugEnabled with SLF4J parameterized log messages. 
> https://www.slf4j.org/faq.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to