Szilard Nemeth created YARN-9355:
------------------------------------

             Summary: RMContainerRequestor#makeRemoteRequest has confusing log 
message
                 Key: YARN-9355
                 URL: https://issues.apache.org/jira/browse/YARN-9355
             Project: Hadoop YARN
          Issue Type: Improvement
            Reporter: Szilard Nemeth


org.apache.hadoop.mapreduce.v2.app.rm.RMContainerRequestor#makeRemoteRequest 
has this log: 

{code:java}
if (ask.size() > 0 || release.size() > 0) {
      LOG.info("getResources() for " + applicationId + ":" + " ask="
          + ask.size() + " release= " + release.size() + " newContainers="
          + allocateResponse.getAllocatedContainers().size()
          + " finishedContainers=" + numCompletedContainers
          + " resourcelimit=" + availableResources + " knownNMs="
          + clusterNmCount);
    }
{code}
The reason why "getResources()" is printed because 
org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator#getResources invokes 
makeRemoteRequest. This is not too informative and error-prone as name of 
getResources could change over time and the log will be outdated. Moreover, 
it's not a good idea to print a method name from a method below the current one 
in the stack.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to