[
https://issues.apache.org/jira/browse/YARN-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szilard Nemeth updated YARN-9361:
---------------------------------
Description:
This is a follow-up for YARN-9323, covering changes regarding explicit zero
value check that has been discussed with [~templedf] earlier.
YARN-9323 fixed a bug in FSLeafQueue#computeMaxAMResource, so that custom
resource values are also set to the AM share.
We need a new test in TestFSLeafQueue that explicitly checks if the custom
resource value is only being set if the fairshare for that resource is zero.
This way, we can make sure we don't overwrite any meaningful resource value.
was:
This is a follow-up for YARN-9323, covering required changes as discussed with
[~templedf] earlier.
After YARN-9323,
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSLeafQueue#computeMaxAMResource
gets the QueueMetricsForCustomResources object from
scheduler.getRootQueueMetrics().
Instead, we should use a "fill-in" method in QueueMetrics that receives a
Resource and fills in custom resource values if they are non-zero.
> Write testcase for FSLeafQueue that explicitly checks if non-zero values are
> not overwritten for custom resources
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-9361
> URL: https://issues.apache.org/jira/browse/YARN-9361
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
>
> This is a follow-up for YARN-9323, covering changes regarding explicit zero
> value check that has been discussed with [~templedf] earlier.
> YARN-9323 fixed a bug in FSLeafQueue#computeMaxAMResource, so that custom
> resource values are also set to the AM share.
> We need a new test in TestFSLeafQueue that explicitly checks if the custom
> resource value is only being set if the fairshare for that resource is zero.
> This way, we can make sure we don't overwrite any meaningful resource value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
