[
https://issues.apache.org/jira/browse/YARN-9363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792994#comment-16792994
]
Prabhu Joseph edited comment on YARN-9363 at 3/14/19 7:35 PM:
--------------------------------------------------------------
[~wilfreds] [~eyang] Have fixed remaining removal of isDebugEnabled and
replace of commons-logging with slf4j. Have left some where the guard is
necessary like multiple log lines, for loop, method calls inside. With this
fix, the commons-logging can be completely removed (YARN-9364). Can you review
this when you get time.
was (Author: prabhu joseph):
[~wilfreds] [~aceric] Have fixed remaining removal of isDebugEnabled and
replace of commons-logging with slf4j. Have left some where the guard is
necessary like multiple log lines, for loop, method calls inside. With this
fix, the commons-logging can be completely removed (YARN-9364). Can you review
this when you get time.
> Replace isDebugEnabled with SLF4J parameterized log messages for remaining
> code
> -------------------------------------------------------------------------------
>
> Key: YARN-9363
> URL: https://issues.apache.org/jira/browse/YARN-9363
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Affects Versions: 3.2.0
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Minor
> Attachments: YARN-9363-001.patch, YARN-9363-002.patch,
> YARN-9363-003.patch
>
>
> Follow up of YARN-9343 to address below review comments
> There are still 200+ LOG.isDebugEnabled() calls in the code. two things:
> There are a lot of simple one parameter calls which could easily be converted
> to unguarded calls, examples:
> NvidiaDockerV1CommandPlugin.java
> FSParentQueue.java
> Application.java
> Some of the calls to LOG.debug that are guarded inside those guards have not
> been changed to parameterized calls yet.
> cc [~wilfreds]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
