[
https://issues.apache.org/jira/browse/YARN-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798744#comment-16798744
]
Vrushali C commented on YARN-9382:
----------------------------------
Thanks Abhishek! Patch v1 LGTM.
Could you update the checkstyle warnings?
{code}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/timelineservice/NMTimelinePublisher.java:277:
entity.setIdPrefix(TimelineServiceHelper.invertLong(containerStartTime));: Line
is longer than 80 characters (found 81). [LineLength]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/timelineservice/TestNMTimelinePublisher.java:27:import
java.util.HashMap;:8: Unused import - java.util.HashMap. [UnusedImports]
{code}
Also, I was wondering, if we can call it
"publishContainerLifeCycleGenericEvent" instead of
"publishContainerGenericEvent" ? Or perhaps Generic Event is fine too.
One other question I had was, should KILLED event have anything that FINISHED
event (publishContainerFinishedEvent) has too? Like the diagnostics, exit info
etc?
> Publish container killed, paused and resumed events to ATSv2.
> -------------------------------------------------------------
>
> Key: YARN-9382
> URL: https://issues.apache.org/jira/browse/YARN-9382
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-9382.001.patch
>
>
> There are some events missing in container lifecycle. We need to add support
> for adding events for when container gets killed, paused and resumed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
