[
https://issues.apache.org/jira/browse/YARN-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800493#comment-16800493
]
Szilard Nemeth commented on YARN-9356:
--------------------------------------
Hi [~zsiegl]!
Looks good. I would also add some more testcases, for example using some
greater values to verify ratio calculation.
You could also use the values the other way around, i.e. resource1's resources
are greater than values of resource2.
> Add more tests to ratio method in TestResourceCalculator
> ---------------------------------------------------------
>
> Key: YARN-9356
> URL: https://issues.apache.org/jira/browse/YARN-9356
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Zoltan Siegl
> Priority: Major
> Attachments: YARN-9356.001.patch
>
>
> TestResourceCalculator has some edge-case testcases to verify how division by
> zero is handled with ResourceCalculator.
> We need other basic tests like we have for other ResourceCalculator methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
