[
https://issues.apache.org/jira/browse/YARN-8551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811232#comment-16811232
]
Eric Yang commented on YARN-8551:
---------------------------------
[~yeshavora] Thank you for the patch 016.
A few nitpicks:
# Add to Example.md to describe what mawo is.
# In WorkerId.java in 53. InetAddress.getLocalhost().getLocalHost() can be
written as InetAddress.getLocalhost()
# MawoConfiguration, line 45, spelling for separator.
# MawoConfiguration, line 80, spelling for property.
# MawoConfiguration, line 234, spelling for initializer.
# ZooKeeper spelling needs capitalizing K.
# TaskType, line 38, spelling for suicide.
# TaskStatus, line 107, spelling for constructor.
# Task, line 38, 62, spelling for environment.
# AbstractTask, line 63, spelling for constructor.
# CompositeTask, line 34, spelling for initializer.
# WorkAssignmentProtocol, line 26, spelling for assignment.
The rest project setup looks good to me.
> Build Common module for MaWo application
> ----------------------------------------
>
> Key: YARN-8551
> URL: https://issues.apache.org/jira/browse/YARN-8551
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Yesha Vora
> Assignee: Yesha Vora
> Priority: Major
> Attachments: YARN-8551.001.patch, YARN-8551.0010.patch,
> YARN-8551.0011.patch, YARN-8551.0012.patch, YARN-8551.0013.patch,
> YARN-8551.0014.patch, YARN-8551.0015.patch, YARN-8551.0016.patch,
> YARN-8551.002.patch, YARN-8551.003.patch, YARN-8551.004.patch,
> YARN-8551.005.patch, YARN-8551.006.patch, YARN-8551.007.patch,
> YARN-8551.008.patch, YARN-8551.009.patch
>
>
> Build Common module for MaWo application.
> This module should include defination of Task. A Task should contain
> * TaskID
> * Task Command
> * Task Environment
> * Task Timeout
> * Task Type
> ** Simple Task
> *** Its a single Task
> ** Composite Task
> *** Its a composition of multiple simple tasks
> ** Teardown Task
> *** Its a last task to be executed after a job is finished
> ** Null Task
> *** Its a null task
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
