[
https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812455#comment-16812455
]
Szilard Nemeth commented on YARN-9460:
--------------------------------------
Hi [~bibinchundatt]!
It's a good idea but ClientRMService does not belong to these ACL manager
classes in any way, so I would file a separate jira if you want to eliminate
instanceof from that class.
> QueueACLsManager and ReservationsACLManager should not use instanceof checks
> ----------------------------------------------------------------------------
>
> Key: YARN-9460
> URL: https://issues.apache.org/jira/browse/YARN-9460
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Priority: Major
>
> QueueACLsManager and ReservationsACLManager should not use instanceof checks
> for the scheduler type.
> Rather, we should abstract this into two classes: Capacity and Fair variants
> of these ACL classes.
> QueueACLsManager and ReservationsACLManager could be abstract classes, but
> the implementation is the decision of one who will work on this jira.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
