[ https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815322#comment-16815322 ]
Szilard Nemeth commented on YARN-9052: -------------------------------------- Hi [~adam.antal]! Thanks for the review! Yep, I agree that this is a massive one, also think that the rebase could be a massive one. I would like to get this in as I think it's a useful patch to have, but I can't guarantee I'm going to have some time in the near future (coming weeks). After I finished some ongoing Submarine development, I can work on this :) > Replace all MockRM submit method definitions with a builder > ----------------------------------------------------------- > > Key: YARN-9052 > URL: https://issues.apache.org/jira/browse/YARN-9052 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Minor > Attachments: YARN-9052.001.patch, YARN-9052.002.patch > > > MockRM has 31 definitions of submitApp, most of them having more than > acceptable number of parameters, ranging from 2 to even 22 parameters, which > makes the code completely unreadable. > On top of unreadability, it's very hard to follow what RmApp will be produced > for tests as they often pass a lot of empty / null values as parameters. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org