[
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816531#comment-16816531
]
Íñigo Goiri commented on YARN-9474:
-----------------------------------
Thanks [~abmodi] for this, getting rid of sleeps is always good.
For the new log lines, can we use the full logger format?
{{LOG.info("Containers: {}", containers);}}
For the waits, I would leave the timeout exception go through as the rest of
the tests do; it's true it's a little verbose but it's clear.
In addition, in the waits we probably want to use lambdas:
{code}
GenericTestUtils.waitFor(() -> amservice.getLeastLoadedNodes().size() == 4);
{code}
> Remove hard coded sleep from Opportunistic Scheduler tests.
> -----------------------------------------------------------
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-9474.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
