[ 
https://issues.apache.org/jira/browse/YARN-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817210#comment-16817210
 ] 

Wanqiang Ji commented on YARN-9453:
-----------------------------------

002 patch fixed all the issues from Yetus.

> Clean up code long if-else chain in ApplicationCLI#run
> ------------------------------------------------------
>
>                 Key: YARN-9453
>                 URL: https://issues.apache.org/jira/browse/YARN-9453
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Wanqiang Ji
>            Priority: Major
>              Labels: newbie
>         Attachments: YARN-9453.001.patch, YARN-9453.002.patch
>
>
> org.apache.hadoop.yarn.client.cli.ApplicationCLI#run is 630 lines long, 
> contains a long if-else chain and many many conditions. 
> As a start, the bodies of the conditions could be extracted to methods and a 
> more clean solution could be introduced to parse the argument values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to