[
https://issues.apache.org/jira/browse/YARN-8943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818234#comment-16818234
]
Akira Ajisaka commented on YARN-8943:
-------------------------------------
Thanks [~tasanuma0829] for reviewing this issue.
bq. Should we remove org.junit.vintage dependency in pom.xml since we don't
consider JUnit4 here?
No, we shouldn't remove the dependency for now. TestYarnConfigurationFields
extends TestConfigurationFieldsBase and it uses JUnit 4 API. If we remove the
dependency, the test does not run.
bq. As we discussed in the thread, we may use AssertJ.
Yes, we may use AssertJ. Let's use it in a separate jira.
> Upgrade JUnit from 4 to 5 in hadoop-yarn-api
> --------------------------------------------
>
> Key: YARN-8943
> URL: https://issues.apache.org/jira/browse/YARN-8943
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: test
> Reporter: Akira Ajisaka
> Assignee: Akira Ajisaka
> Priority: Major
> Attachments: YARN-8943.01.patch, YARN-8943.02.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
