[ 
https://issues.apache.org/jira/browse/YARN-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819703#comment-16819703
 ] 

Tao Yang commented on YARN-9490:
--------------------------------

Thanks [~zyb] for raising this issue.
The patch makes sense to me, just a small suggestion: we can iterate values if 
no need to access the keys, and a simpler way is to use stream like this: 
this.reservedContainers.values().stream().mapToInt(Map::size).sum();

> applicationresourceusagereport return wrong number of reserved containers
> -------------------------------------------------------------------------
>
>                 Key: YARN-9490
>                 URL: https://issues.apache.org/jira/browse/YARN-9490
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.3.0
>            Reporter: yanbing zhang
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: YARN-9490.patch
>
>
> when getting an ApplicationResourceUsageReport instance from the class of 
> SchedulerApplicationAttempt, I found the input constructor 
> parameter(reservedContainers.size()) is wrong.  because the type of this 
> variable is Map<SchedulerRequestKey, Map<NodeId, RMContainer>>, so 
> "reservedContainer.size()" is not the number of containers, but the number of 
> SchedulerRequestKey.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to