[
https://issues.apache.org/jira/browse/YARN-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820340#comment-16820340
]
Sunil Govindan commented on YARN-9475:
--------------------------------------
Thanks [~pbacsko]. Few comments
# Below code segment could be placed as a common log to print *binaryName* .
{{LOG.info("Use {} as script name.", envScriptName)}}
# In {{getScriptFromEnvSetting}}, all the logs under error condition should
also have the path variable append to it to make it more readable.
# In $HADOOP_COMMON_HOME section, where we check {{if (envBinaryPath != null)
{}} again in line no:89., i think log is not correct. pls check once. we seems
printing falling back to envBinaryPath again.I am not sure whether is correct
# Do we need to continue or break here
{code:java}
166 if (tokens.length != 2) {
167 LOG.error("Unknown format of script output! Skipping this line");
168 break;
169 }{code}
> Create basic VE plugin
> ----------------------
>
> Key: YARN-9475
> URL: https://issues.apache.org/jira/browse/YARN-9475
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: YARN-9475-001.patch, YARN-9475-002.patch,
> YARN-9475-003.patch, YARN-9475-004.patch, YARN-9475-005.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
