[
https://issues.apache.org/jira/browse/YARN-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826097#comment-16826097
]
Szilard Nemeth commented on YARN-9476:
--------------------------------------
Hi [~pbacsko]!
Latest patch loogs good, except one minor thing I suggested before:
Please store the result of
{code:java}
f.mkdirs()
{code}
and have an assertion on the value.
I meant a similar thing for when you are setting the executable flag of the
files:
{code:java}
scriptPath.toFile().setExecutable(true)
{code}
Please store the value and assert if it is true.
Thanks!
> Create unit tests for VE plugin
> -------------------------------
>
> Key: YARN-9476
> URL: https://issues.apache.org/jira/browse/YARN-9476
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: YARN-9476-001.patch, YARN-9476-002.patch,
> YARN-9476-003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
