[
https://issues.apache.org/jira/browse/YARN-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831916#comment-16831916
]
Íñigo Goiri commented on YARN-9505:
-----------------------------------
Thanks [~abmodi] for the fixes.
I think we need to have more comments.
In particular, {{allocateLatencyOQuantiles}} should have the metric annotation
explaining what it represents.
It has it on the {{initialize()}} but I'm not sure is the same, in any case it
should have the same format as others with "Aggregate # of...".
Regarding the test, a few minor comments:
* Can we use {{Collecitons#emptyList()}} instead of {{new ArrayList}}?
* The test could use some high level comments too.
* There are a bunch of things that are used over and over, we could do:
** EXEC_OPPORTUNISTIC =
ExecutionTypeRequest.newInstance(ExecutionType.OPPORTUNISTIC, true)
** RESOURCE_1GB = Resources.createResource(1 * GB)
** PRIORITY_1 = Priority.newInstance(1)
> Add container allocation latency for Opportunistic Scheduler
> ------------------------------------------------------------
>
> Key: YARN-9505
> URL: https://issues.apache.org/jira/browse/YARN-9505
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-9505.001.patch, YARN-9505.002.patch,
> YARN-9505.003.patch
>
>
> This will help in tuning the opportunistic scheduler and it's configuration
> parameters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
