[ 
https://issues.apache.org/jira/browse/YARN-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833711#comment-16833711
 ] 

Adam Antal commented on YARN-9513:
----------------------------------

I got a chance to run this test on multiple JDKs, and it turns out that it has 
nothing to do with being the OpenJDK.  The names of the GCs have been changed 
since Java 1.9, so we should only do a version check.

Tested patch v1 against the following JDKs:
- 8.0.202-zulu
- 9.0.4-open
- 9.0.7-zulu
- 10.0.2-open
- 10.0.2-zulu
- 11.0.2-open
- 11.0.3-zulu
They all passed on my local.

I also checked other occurrences of {{GarbageCollectorMXBean}} and it looks 
like it is mostly used for calculating GC-related metrics, but the names are 
never hardcoded besides the invariants.txt, so it is not expected to cause 
issues anywhere else.

> [JDK11] TestMetricsInvariantChecker#testManyRuns InvariantViolationException: 
> ReferenceError: "GcCountPS_Scavenge" is not defined in <eval> at line number 1
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-9513
>                 URL: https://issues.apache.org/jira/browse/YARN-9513
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>            Reporter: Siyao Meng
>            Assignee: Adam Antal
>            Priority: Major
>         Attachments: YARN-9513.001.patch
>
>
> Found in maven JDK 11 unit test run. Compiled on JDK 8:
> {code}
> [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.502 
> s<<< FAILURE! - in 
> org.apache.hadoop.yarn.server.resourcemanager.monitor.invariants.TestMetricsInvariantChecker
> [ERROR] 
> testManyRuns(org.apache.hadoop.yarn.server.resourcemanager.monitor.invariants.TestMetricsInvariantChecker)
>   Time elapsed: 0.206 s  <<< 
> ERROR!org.apache.hadoop.yarn.server.resourcemanager.monitor.invariants.InvariantViolationException:
>  ReferenceError: "GcCountPS_Scavenge" is not defined in <eval> at line number 
> 1
>         at 
> org.apache.hadoop.yarn.server.resourcemanager.monitor.invariants.InvariantsChecker.logOrThrow(InvariantsChecker.java:74)
>         at 
> org.apache.hadoop.yarn.server.resourcemanager.monitor.invariants.MetricsInvariantChecker.editSchedule(MetricsInvariantChecker.java:180)
>         at 
> org.apache.hadoop.yarn.server.resourcemanager.monitor.invariants.TestMetricsInvariantChecker.testManyRuns(TestMetricsInvariantChecker.java:69)
>         at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>         at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>         at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>         at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>         at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>         at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>         at 
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to