[ 
https://issues.apache.org/jira/browse/YARN-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841726#comment-16841726
 ] 

Szilard Nemeth commented on YARN-9546:
--------------------------------------

Hi [~shuzirra]!
Thanks for this patch!

LGTM in overral, just one thing.
In ServiceUtils: 

{code:java}
if (!configClassPath.isEmpty()) {
      classpath.appendAll(Arrays.asList(configClassPath.split(",")));
    }
{code}

Is it ensured that configClassPath could be split across commas? Is it a sure 
thing that the value contains commas? Can we experience any issues if it does 
not have that?

Thanks!


> Add configuration option for yarn services AM classpath
> -------------------------------------------------------
>
>                 Key: YARN-9546
>                 URL: https://issues.apache.org/jira/browse/YARN-9546
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Gergely Pollak
>            Assignee: Gergely Pollak
>            Priority: Major
>         Attachments: YARN-9546.001.patch, YARN-9546.002.patch
>
>
> For regular containers we have the yarn.application.classpath property, which 
> allows users to add extra elements to the container's classpath. 
> However yarn services deliberately ignores this property to avoid 
> incompatible class collision. However on systems where the configuration 
> files for containers are located other than the path stored in 
> $HADOOP_CONF_DIR, there is no way to modify the classpath to include other 
> directories with the actual configuration.
> Suggestion let's create a new property which allows us to add extra elements 
> to the classpath generated for YARN service AM containers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to