[ 
https://issues.apache.org/jira/browse/YARN-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841881#comment-16841881
 ] 

Tao Yang edited comment on YARN-9497 at 5/17/19 3:43 AM:
---------------------------------------------------------

Thanks [~cheersyang] for the review and suggestions.
{quote}we can rename {{STATE_AND_DIAGNOSTIC}} to {{diagnostic}}, because I 
don't expect different activity state would have the same diagnostic messages
{quote}
Some states may not have diagnostic such as ALLOCATED and RESERVED, group by 
diagnostic means we will ignore the state dimension, I think it's better that 
the aggregated results can be shown with state like: [{"state":"ALLOCATED", 
count: 5, nodeIds:[....]}, \{"state":"SKIPPED", diagnostic:"insufficient 
resource: [memory]", count: 100, nodeIds:[....]}, ......]. Thoughts?

Other suggestions make sense to me.


was (Author: tao yang):
Thanks [~cheersyang] for the review and suggestions.

{quote}

we can rename {{STATE_AND_DIAGNOSTIC}} to {{diagnostic}}, because I don't 
expect different activity state would have the same diagnostic messages

{quote}

Some states may not have diagnostic such as ALLOCATED and RESERVED, group by 
diagnostic means we will ignore the state dimension, I think it's better that 
the aggregated results can be shown with state like: [\{"state":"ALLOCATED", 
count: 5, nodeIds:[....]}, {"state":"SKIPPED", diagnostic:"insufficient 
resource: [memory]", count: 100, nodeIds:[....]}, ......]. Thoughts?

Other suggestions make sense to me.

> Support grouping by diagnostics for query results of scheduler and app 
> activities
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-9497
>                 URL: https://issues.apache.org/jira/browse/YARN-9497
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Tao Yang
>            Assignee: Tao Yang
>            Priority: Major
>         Attachments: YARN-9497.001.patch, YARN-9497.002.patch
>
>
> [Design Doc 
> #4.3|https://docs.google.com/document/d/1pwf-n3BCLW76bGrmNPM4T6pQ3vC4dVMcN2Ud1hq1t2M/edit#heading=h.6fbpge17dmmr]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to