[
https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844311#comment-16844311
]
Jim Brennan commented on YARN-9561:
-----------------------------------
[~ebadger] thanks for the patch! I did an extensive review of this C code when
we added it to our internal 2.8-based branch, and we have been running with it
since January. So for this review, I compared our internal code to this code
to verify the minor changes you had to make to the new files, and then
concentrated on the diffs from trunk in the modified files. This code looks
good to me.
I had one minor nit: in container-executor.c, we will likely need to add a call
to create_yarn_sysfs() in setup_container_paths(), but we might not need it
right away.
> Add C changes for the new OCI/squashfs/runc runtime
> ---------------------------------------------------
>
> Key: YARN-9561
> URL: https://issues.apache.org/jira/browse/YARN-9561
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Eric Badger
> Assignee: Eric Badger
> Priority: Major
> Attachments: YARN-9561.001.patch, YARN-9561.002.patch
>
>
> This JIRA will be used to add the C changes to the container-executor native
> binary that are necessary for the new OCI/squashFS/runc runtime. There should
> be no changes to existing code paths.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
