[
https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846225#comment-16846225
]
Eric Yang edited comment on YARN-9561 at 5/22/19 8:58 PM:
----------------------------------------------------------
[~ebadger] Can we have some test cases? Hadoop C is using K&R style brace
placement, cJSON code is using Allman style brace placement. It is a little
confusing to see them in the same directory. Would it be better to place cJSON
files in a vendor sub-directory to ensure that we don't make modification to
the source and easier to rebase to upstream?
was (Author: eyang):
[~ebadger] Can we have some test cases? Hadoop C is using K&R style brace
placement, cJSON code is using Allman style brace placement. It is a little
confusing to see them in the directory. Would it be better to place cJSON
files in a vendor sub-directory to ensure that we don't make modification to
the source and easier to rebase to upstream?
> Add C changes for the new OCI/squashfs/runc runtime
> ---------------------------------------------------
>
> Key: YARN-9561
> URL: https://issues.apache.org/jira/browse/YARN-9561
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Eric Badger
> Assignee: Eric Badger
> Priority: Major
> Attachments: YARN-9561.001.patch, YARN-9561.002.patch
>
>
> This JIRA will be used to add the C changes to the container-executor native
> binary that are necessary for the new OCI/squashFS/runc runtime. There should
> be no changes to existing code paths.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
