[
https://issues.apache.org/jira/browse/YARN-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847712#comment-16847712
]
Eric Yang edited comment on YARN-9560 at 5/24/19 4:44 PM:
----------------------------------------------------------
[~ebadger] Are there two JSON formats used in OCIContainerRuntime? One for
passing information between Java and C, and another passed to runc for
execution? If there is only one format that the one passing from Java is
consumed by runc, then I agree with you that it is not easy to pass this flag
and follow up JIRA make sense to further develop communication filtering
between Java, container-executor and runc. If there is already two types of
JSON messages setup for communication between Java-container-executor and
container-executor-runc, then it would be better to have sysfs included for
communication between Java and container-executor. Container-executor binary
needs to handle how to translate the flag into meaningful mount operations for
runc.
was (Author: eyang):
[~ebadger] Are there two JSON formats used in OCIContainerRuntime? One for
passing information between Java and C, and another passed to runc for
execution? If there is only one format that the one passing from Java is
consumed by runc, then I agree with you that it is not easy to pass this flag
and follow up JIRA make sense to further develop communication filtering
between Java, container-executor and runc. If there is already two types of
JSON messages setup for communication between Java <-> container-executor and
container-executor <-> runc, then it would be better to have sysfs included for
communication between Java and container-executor. Container-executor binary
needs to handle how to translate the flag into meaningful mount operations for
runc.
> Restructure DockerLinuxContainerRuntime to extend a new OCIContainerRuntime
> ---------------------------------------------------------------------------
>
> Key: YARN-9560
> URL: https://issues.apache.org/jira/browse/YARN-9560
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Eric Badger
> Assignee: Eric Badger
> Priority: Major
> Attachments: YARN-9560.001.patch, YARN-9560.002.patch,
> YARN-9560.003.patch, YARN-9560.004.patch, YARN-9560.005.patch,
> YARN-9560.006.patch
>
>
> Since the new OCI/squashFS/runc runtime will be using a lot of the same code
> as DockerLinuxContainerRuntime, it would be good to move a bunch of the
> DockerLinuxContainerRuntime code up a level to an abstract class that both of
> the runtimes can extend.
> The new structure will look like:
> {noformat}
> OCIContainerRuntime (abstract class)
> - DockerLinuxContainerRuntime
> - FSImageContainerRuntime (name negotiable)
> {noformat}
> This JIRA should only change the structure of the code, not the actual
> semantics
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
