[
https://issues.apache.org/jira/browse/YARN-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849295#comment-16849295
]
Zhankun Tang commented on YARN-9584:
------------------------------------
[~jiwq], does it cost much effort to do refactoring for that method? if too
much, I'll get this in without test case.
> Should put initializeProcessTrees method call before get pid
> ------------------------------------------------------------
>
> Key: YARN-9584
> URL: https://issues.apache.org/jira/browse/YARN-9584
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.2.0, 3.0.3, 3.1.2
> Reporter: Wanqiang Ji
> Assignee: Wanqiang Ji
> Priority: Critical
> Attachments: YARN-9584.001.patch
>
>
> In ContainerMonitorImpl#MonitoringThread.run method had a logical error that
> get pid first then initialize uninitialized process trees.
> {code:java}
> String pId = ptInfo.getPID();
> // Initialize uninitialized process trees
> initializeProcessTrees(entry);
> if (pId == null || !isResourceCalculatorAvailable()) {
> continue; // processTree cannot be tracked
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
