[
https://issues.apache.org/jira/browse/YARN-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799969#comment-13799969
]
Hadoop QA commented on YARN-1327:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12609276/nodemgr-portability.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/2230//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2230//console
This message is automatically generated.
> Fix nodemgr native compilation problems on FreeBSD9
> ---------------------------------------------------
>
> Key: YARN-1327
> URL: https://issues.apache.org/jira/browse/YARN-1327
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Assignee: Radim Kolar
> Fix For: 3.0.0, 2.2.1
>
> Attachments: nodemgr-portability.txt
>
>
> There are several portability problems preventing from compiling native
> component on freebsd.
> 1. libgen.h is not included. correct function prototype is there but linux
> glibc has workaround to define it for user if libgen.h is not directly
> included. Include this file directly.
> 2. query max size of login name using sysconf. it follows same code style
> like rest of code using sysconf too.
> 3. cgroups are linux only feature, make conditional compile and return error
> if mount_cgroup is attempted on non linux OS
> 4. do not use posix function setpgrp() since it clashes with same function
> from BSD 4.2, use equivalent function. After inspecting glibc sources its
> just shortcut to setpgid(0,0)
> These changes makes it compile on both linux and freebsd.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
