[ 
https://issues.apache.org/jira/browse/YARN-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800097#comment-13800097
 ] 

Tsuyoshi OZAWA commented on YARN-1328:
--------------------------------------

+1 for exposing ContainerId prefix. There are lots places where containerId's 
prefix is used(e.g. test cases).

IMO, we should use snake case with upper case like CONTAINER_ID_PREFIX instead 
of using camel case when we define constants.  I think 
appIdStrPrefix/appAttemptIdStrPrefix should also be fixed.

> ContainerId should expose a public static string of the ID's prefix
> -------------------------------------------------------------------
>
>                 Key: YARN-1328
>                 URL: https://issues.apache.org/jira/browse/YARN-1328
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>            Priority: Minor
>         Attachments: YARN-1328.1.patch
>
>
> Like ApplicationId and ApplicationAttemptId, ContainerId should also have 
> public static string:
> {code}
>   public static final String containerIdStrPrefix = "container_";
> {code}
> Others can refer to this string to verify a containerId string.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to