[ 
https://issues.apache.org/jira/browse/YARN-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857495#comment-16857495
 ] 

Weiwei Yang commented on YARN-9578:
-----------------------------------

Hi [~Tao Yang]

Thanks for the patch. A few comments here

1. ActivitiesManager#getAppActivitiesInfo

Since you are supporting a limit number of records here, instead of cutting off 
from a full list, can it be done while generating the allocations?

Is there a default value for this limit?

2. RMWebServices#getAppActivities

I am a bit confused by query parameter ACTIONS, it looks like this is always 
required. But the form is not a very RESTful pattern. Instead, I am expecting 
the query URL looks like
{code:java}
/scheduler/app-activities/app-id/get?xxx
/scheduler/app-activities/app-id/update?xxx
{code}
3. RMConstants#AppActivitiesRequiredAction

Can we rename "UPDATE" to "REFRESH"?

Thanks

> Add limit/actions/summarize options for app activities REST API
> ---------------------------------------------------------------
>
>                 Key: YARN-9578
>                 URL: https://issues.apache.org/jira/browse/YARN-9578
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Tao Yang
>            Assignee: Tao Yang
>            Priority: Major
>         Attachments: YARN-9578.001.patch, YARN-9578.002.patch, 
> YARN-9578.003.patch, YARN-9578.004.patch, YARN-9578.005.patch
>
>
> Currently all completed activities of specified application in cache will be 
> returned forĀ application activities REST API. Most results may be redundant 
> in some scenarios which only need a few latest results, for example, perhaps 
> only one result is needed to be shown on UI for debugging.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to