[
https://issues.apache.org/jira/browse/YARN-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861943#comment-16861943
]
Zhankun Tang edited comment on YARN-9608 at 6/12/19 10:24 AM:
--------------------------------------------------------------
Thanks for the patch! [~abmodi].
I took a glance at it. Some minor questions:
1. Is the "rmNode.getRunningApps()" deliberate?
{code:java}
DecommissioningNodeContext context = decomNodes.get(rmNode.getNodeID());
rmNode.getRunningApps();
long now = mclock.getTime();{code}
2. Do we need to update the comment below?
{code:java}
// All applications run on the node at or after decommissioningStartTime.
private List<ApplicationId> appIds;
{code}
was (Author: tangzhankun):
Thanks for the patch! [~abmodi].
I took a glance at it. Some minor question:
Is the "rmNode.getRunningApps()" deliberate?
{code:java}
DecommissioningNodeContext context = decomNodes.get(rmNode.getNodeID());
rmNode.getRunningApps();
long now = mclock.getTime();{code}
> DecommissioningNodesWatcher should get lists of running applications on node
> from RMNode.
> -----------------------------------------------------------------------------------------
>
> Key: YARN-9608
> URL: https://issues.apache.org/jira/browse/YARN-9608
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-9608.001.patch
>
>
> At present, DecommissioningNodesWatcher tracks list of running applications
> and triggers decommission of nodes when all the applications that ran on the
> node completes. This Jira proposes to solve following problem:
> # DecommissioningNodesWatcher skips tracking application containers on a
> particular node before the node is in DECOMMISSIONING state. It only tracks
> containers once the node is in DECOMMISSIONING state. This can lead to
> shuffle data loss of apps whose containers ran on this node before it was
> moved to decommissioning state.
> # It is keeping track of running apps. We can leverage this directly from
> RMNode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
