[
https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801056#comment-13801056
]
Mayank Bansal commented on YARN-947:
------------------------------------
[~zjshen]
Some comments:
ApplicationAttemptFinishData should not have FinalApplicationStatus as we
already removed them as part of attempt report.
SImilarly from ApplicationAttemptHistoryData also should not contain
FinalApplicationStatus
Instead they should contain ApplicationAttemptState.
Same comments for the PB classes
> Defining the history data classes for the implementation of the
> reading/writing interface
> -----------------------------------------------------------------------------------------
>
> Key: YARN-947
> URL: https://issues.apache.org/jira/browse/YARN-947
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Fix For: YARN-321
>
> Attachments: YARN-947.1.patch, YARN-947.2.patch, YARN-947.3.patch,
> YARN-947.4.patch, YARN-947.5.patch
>
>
> We need to define the history data classes have the exact fields to be
> stored. Therefore, all the implementations don't need to have the duplicate
> logic to exact the required information from RMApp, RMAppAttempt and
> RMContainer.
> We use protobuf to define these classes, such that they can be ser/des
> to/from bytes, which are easier for persistence.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
