[
https://issues.apache.org/jira/browse/YARN-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867716#comment-16867716
]
Adam Antal commented on YARN-9607:
----------------------------------
Uploaded patch v2.
There has been changed a lot since the last updated, and let me update each and
every one of you:
[~sunilg] I think introducing a global config is not a good idea. The problem
is that a global configuration is not depending on the filesystem: we still
have to get the information whether the filesystem supports append or not, and
it makes no sense to disable that configuration: that would make it broken
anyways. The cleanest and easiest solution to collect the schemes that we want
to support, and add a contract-based test (look YARN-9525).
[~wangda]: the config is now enforced.
I also removed s3n since it's deprecated, and I missed the fact the wasb and
adls supports append (according to their filesystem contract xml).
[[email protected]], I don't know whether do we have to explicitly define the
set of filesystems where append is not supported. I didn't find any elegant way
to get this information (whether append is supported) directly from either the
FileSystem or its subclass. Any suggestions on that one?
[~snemeth]: Since the tests got removed, so the first point of yours is no
longer valid. The other ones are incorporated in the patch.
The tests got removed, since I make a comprehensive filesystem contract based
test in YARN-9525 which will also incorporate the checking of rollover size.
Jenkins will probably say a -1 on this, but this is a precondition of
YARN-9525, so we have to push this in first.
Let me know if you have any concerns.
> Auto-configuring rollover-size of IFile format for non-appendable filesystems
> -----------------------------------------------------------------------------
>
> Key: YARN-9607
> URL: https://issues.apache.org/jira/browse/YARN-9607
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: log-aggregation, yarn
> Affects Versions: 3.3.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
> Attachments: YARN-9607.001.patch, YARN-9607.002.patch
>
>
> In YARN-9525, we made IFile format compatible with remote folders with s3a
> scheme. In rolling fashioned log-aggregation IFile still fails with the
> "append is not supported" error message, which is a known limitation of the
> format by design.
> There is a workaround though: setting the rollover size in the configuration
> of the IFile format, in each rolling cycle a new aggregated log file will be
> created, thus we eliminated the append from the process. Setting this config
> globally would cause performance problems in the regular log-aggregation, so
> I'm suggesting to enforcing this config to zero, if the scheme of the URI is
> s3a (or any other non-appendable filesystem).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
