[ 
https://issues.apache.org/jira/browse/YARN-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867747#comment-16867747
 ] 

Prabhu Joseph commented on YARN-9374:
-------------------------------------

Thanks [~snemeth] for reviewing.

1. Have changed the variable name from hbi to writer.
2. Was assuming wrongly that Exception at that point will only mean 
HbaseStorageMonitor failed to detect Hbase Up. Have modified the testcase 
little bit and the assertion message to be more clear.

> HBaseTimelineWriterImpl sync writes has to avoid thread blocking if storage 
> down
> --------------------------------------------------------------------------------
>
>                 Key: YARN-9374
>                 URL: https://issues.apache.org/jira/browse/YARN-9374
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: ATSv2
>    Affects Versions: 3.2.0
>            Reporter: Prabhu Joseph
>            Assignee: Prabhu Joseph
>            Priority: Major
>         Attachments: YARN-9374-001.patch, YARN-9374-002.patch, 
> YARN-9374-003.patch, YARN-9374-004.patch
>
>
> HBaseTimelineWriterImpl sync writes has to avoid thread blocking if storage 
> is down. Currently we check if hbase storage is down in TimelineReader before 
> reading entities and fail immediately in YARN-8302. Similar fix is needed for 
> write. Async is handled in YARN-9335.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to