[
https://issues.apache.org/jira/browse/YARN-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868490#comment-16868490
]
Adam Antal commented on YARN-9559:
----------------------------------
Hi,
Thanks for the patch [~jhung].
Generally I think this logic would better suit an interface. The interface
would have the {{handle}} and probably an other function (e.g. {{init}})
handling the other parameters, so those would not be enforced to be given in
construction time. Also by using implements we don't force the class hierarchy
- hence it is possible to have your class extending some other class which may
partially contain the logic you want to use here.
If the interface is not compatible with the {{Configuration.getClass}} call,
then please ignore my comment. Anyways, in that case the public constructor
with the String-only parameter should not be there (what would prevent users of
this class from calling that constructor).
> Create AbstractContainersLauncher for pluggable ContainersLauncher logic
> ------------------------------------------------------------------------
>
> Key: YARN-9559
> URL: https://issues.apache.org/jira/browse/YARN-9559
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Jonathan Hung
> Assignee: Jonathan Hung
> Priority: Major
> Attachments: YARN-9559.001.patch, YARN-9559.002.patch,
> YARN-9559.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
