[
https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803245#comment-13803245
]
Vinod Kumar Vavilapalli commented on YARN-956:
----------------------------------------------
Quick comments on the patch:
- Don't like the statics. We are eventually going to run multiple tests in
parallel and statics in InMemoryHistoryStorage will bite us.
- If we get rid of the static data, testWriteApplicationHistoryAgain(),
classTearDown(), "+ //The order of the test cases matters" etc are useless?
- "is already presented" -> "is already stored" everywhere.
- TestApplicationHistoryStore: Rename it to ApplicationHistoryStoreTestUtils?
> [YARN-321] Add a testable in-memory HistoryStorage
> ---------------------------------------------------
>
> Key: YARN-956
> URL: https://issues.apache.org/jira/browse/YARN-956
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Zhijie Shen
> Fix For: YARN-321
>
> Attachments: YARN-956-1.patch, YARN-956-2.patch, YARN-956-3.patch,
> YARN-956.4.patch, YARN-956.5.patch, YARN-956.6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
