[ 
https://issues.apache.org/jira/browse/YARN-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903702#comment-16903702
 ] 

Hudson commented on YARN-9096:
------------------------------

FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17071 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/17071/])
YARN-9096: Some GpuResourcePlugin and ResourcePluginManager methods are 
(snemeth: rev 742e30b47381ad63e2b2fe63738cd0fe6cbce106)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/gpu/GpuResourcePlugin.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/ResourcePluginManager.java


> Some GpuResourcePlugin and ResourcePluginManager methods are synchronized 
> unnecessarily
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-9096
>                 URL: https://issues.apache.org/jira/browse/YARN-9096
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Gergely Pollak
>            Priority: Major
>             Fix For: 3.3.0, 3.2.1, 3.1.3
>
>         Attachments: YARN-9096.001.patch, YARN-9096.002.patch, 
> YARN-9096.002.patch
>
>
> These methods are not used concurrently, they are part of the initialization 
> code of NM that happens from one thread.
> This is the list of the call hierarchies: 
> 1. GpuResourcePlugin.initialize + ResourcePluginManager.initialize
>  
> {code:java}
> GpuResourcePlugin.initialize(Context) 
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
>  ResourcePluginManager.initialize(Context) 
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin) 
> NodeManager.serviceInit(Configuration) 
> (org.apache.hadoop.yarn.server.nodemanager){code}
>  
>  
> 2. GpuResourcePlugin.createResourceHandler: 
>  
> {code:java}
> GpuResourcePlugin.createResourceHandler(Context, CGroupsHandler, 
> PrivilegedOperationExecutor) 
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
>  ResourceHandlerModule.addHandlersFromConfiguredResourcePlugins(List, 
> Configuration, Context) 
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources) 
> ResourceHandlerModule.initializeConfiguredResourceHandlerChain(Configuration, 
> Context) 
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources) 
> ResourceHandlerModule.getConfiguredResourceHandlerChain(Configuration, 
> Context) 
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources) 
> ContainerScheduler.serviceInit(Configuration) 
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.scheduler) 
> LinuxContainerExecutor.init(Context) 
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}
>  
> 3. GpuResourcePlugin.getNodeResourceHandlerInstance: 
>  
> {code:java}
> GpuResourcePlugin.getNodeResourceHandlerInstance() 
> (org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu)
> NodeStatusUpdaterImpl.updateConfiguredResourcesViaPlugins(Resource)(2 usages) 
> (org.apache.hadoop.yarn.server.nodemanager)
> NodeStatusUpdaterImpl.serviceInit(Configuration) 
> (org.apache.hadoop.yarn.server.nodemanager)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to