[ 
https://issues.apache.org/jira/browse/YARN-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803516#comment-13803516
 ] 

Hadoop QA commented on YARN-1163:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12609947/YARN-1163-v2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/2267//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2267//console

This message is automatically generated.

> Cleanup code for AssignMapsWithLocality() in RMContainerAllocator
> -----------------------------------------------------------------
>
>                 Key: YARN-1163
>                 URL: https://issues.apache.org/jira/browse/YARN-1163
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: applications
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>         Attachments: YARN-1163-v1.patch, YARN-1163-v2.patch
>
>
> In RMContainerAllocator, AssignMapsWithLocality() is a very important method 
> to assign map tasks on allocated containers with conforming different level 
> of locality (dataLocal, rackLocal, etc.). However, this method messed with 
> different code logic to handle different type of locality but have lots of 
> similar behaviours. This is hard to maintain as well as do extension with 
> other locality type, so we need some more clear code here.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to