[ 
https://issues.apache.org/jira/browse/YARN-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805046#comment-13805046
 ] 

Karthik Kambatla commented on YARN-1172:
----------------------------------------

The high-level approach of having all the *SecretManagers extend 
SecretManagerService instead of each of them implementing a Service separately 
seems more reasonable.

That said, the approach still feels a little round-about. If there are no 
disadvantages (I don't see any) to have SecretManager extend an 
AbstractService, we should attempt doing that. I feel that would simplify 
everything significantly. Let us discuss the merits of having SecretManager 
extend an AbstractService on HADOOP-10043.

I am unable to apply the patch, looks like it has been created without the 
--no-prefix option. Can you upload a new patch that can be applied with patch 
-p0.


> Convert *SecretManagers in the RM to services
> ---------------------------------------------
>
>                 Key: YARN-1172
>                 URL: https://issues.apache.org/jira/browse/YARN-1172
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.1.0-beta
>            Reporter: Karthik Kambatla
>            Assignee: Tsuyoshi OZAWA
>         Attachments: YARN-1172.1.patch, YARN-1172.2.patch, YARN-1172.3.patch, 
> YARN-1172.4.patch, YARN-1172.5.patch, YARN-1172.6.patch, YARN-1172.7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to