[
https://issues.apache.org/jira/browse/YARN-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805494#comment-13805494
]
Zhijie Shen commented on YARN-674:
----------------------------------
I've a quick look at the patch. Here're my comments:
1. It seem that the change in RMAppManager is not necessary, because the
current logic is to reject the app in the secure case when parsing the
credentials and adding the apps to DelegationTokenRenewer have something wrong;
otherwise, the app will be accepted. Though there's no obvious "if... else..."
structure, it achieves the same logic control via:
{code}
throw RPCUtil.getRemoteException(ie);
{code}
I think the exception needs to be thrown, which is missing in your patch. The
exception will notice the client that the app submission fails; otherwise, the
client will think the submission succeeds?
If I miss some ideas here, please let me know.
2. Since DelegationTokenRenewer#addApplication becomes asynchronous, what will
the impact of that the application is already accepted and starts its life
cycle, while DelegationTokenRenewer is so slow to
DelegationTokenRenewerAppSubmitEvent. Will the application fail somewhere else
due to the fresh token unavailable?
3. I noticed testConncurrentAddApplication has been removed. Does the change
affect the current app submission?
> Slow or failing DelegationToken renewals on submission itself make RM
> unavailable
> ---------------------------------------------------------------------------------
>
> Key: YARN-674
> URL: https://issues.apache.org/jira/browse/YARN-674
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Omkar Vinit Joshi
> Attachments: YARN-674.1.patch
>
>
> This was caused by YARN-280. A slow or a down NameNode for will make it look
> like RM is unavailable as it may run out of RPC handlers due to blocked
> client submissions.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
