[ 
https://issues.apache.org/jira/browse/YARN-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920337#comment-16920337
 ] 

Abhishek Modi edited comment on YARN-7982 at 9/1/19 8:07 AM:
-------------------------------------------------------------

Thanks [~Prabhu Joseph] for clarification.

Some minor comments:
 # In FileSystemTimelineReaderImpl, we should set userId only if it is passed 
as null.
 # Would it be possible to write unit test covering case where user id is not 
specified.

 


was (Author: abmodi):
Thanks [~Prabhu Joseph] for clarification.

Some minor comments:
 # In FileSystemTimelineReaderImpl, we should set userId only if it is null.
 # Would it be possible to write unit test covering case where user id is not 
specified.

 

> Do ACLs check while retrieving entity-types per application
> -----------------------------------------------------------
>
>                 Key: YARN-7982
>                 URL: https://issues.apache.org/jira/browse/YARN-7982
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Rohith Sharma K S
>            Assignee: Prabhu Joseph
>            Priority: Major
>         Attachments: YARN-7982-001.patch, YARN-7982-002.patch, 
> YARN-7982-003.patch
>
>
> REST end point {{/apps/$appid/entity-types}} retrieves all the entity-types 
> for given application. This need to be guarded with ACL check
> {code}
> [yarn@yarn-ats-3 ~]$ curl 
> "http://yarn-ats-3:8198/ws/v2/timeline/apps/application_1552297011473_0002?user.name=ambari-qa1";
> {"exception":"ForbiddenException","message":"java.lang.Exception: User 
> ambari-qa1 is not allowed to read TimelineService V2 
> data.","javaClassName":"org.apache.hadoop.yarn.webapp.ForbiddenException"}
> [yarn@yarn-ats-3 ~]$ curl 
> "http://yarn-ats-3:8198/ws/v2/timeline/apps/application_1552297011473_0002/entity-types?user.name=ambari-qa1";
> ["YARN_APPLICATION_ATTEMPT","YARN_CONTAINER"]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to