[
https://issues.apache.org/jira/browse/YARN-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927699#comment-16927699
]
Íñigo Goiri commented on YARN-9782:
-----------------------------------
Thanks [~abmodi] for checking; can we file a separate JIRA to make the delete
resilient?
Regarding the patch itself, a few minor comments:
* It would be better to have the long comment as a javadoc instead of a comment
in the caller.
* Let's rename enableDnsCaching to enableDNSCaching().
* Let's import the assertEquals() instead of calling Assert all the time.
* It may be good to have "networkaddress.cache.ttl" and
"networkaddress.cache.negative.ttl" defined somewhere. No lib containing this
already?
> Avoid DNS resolution while running SLS.
> ---------------------------------------
>
> Key: YARN-9782
> URL: https://issues.apache.org/jira/browse/YARN-9782
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-9782.001.patch, YARN-9782.002.patch,
> YARN-9782.003.patch
>
>
> In SLS, we add nodes with random names and rack. DNS resolution of these
> nodes takes around 2 seconds because it will timeout after that. This makes
> the result of SLS unreliable and adds spikes.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
