[
https://issues.apache.org/jira/browse/YARN-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933646#comment-16933646
]
Jonathan Hung commented on YARN-9762:
-------------------------------------
Thx [~mkumar1984] for the patch, a few issues:
* Can we keep the whitespace changes to a minimum? e.g. the logFailure in
ClientRMService, we can just add an extra line which adds the submissioncontext
nodelabelexpression. Also a few of the LOG.warns in RMAuditLogger, there's a
few unnecessary newline changes. It keeps the git blame cleaner if we minimize
these changes.
* There seems to be a lot of unnecessary whitespace in the added
RMAuditLogger#logFailure javadoc (after the argument names, + before the Note
at the bottom of the javadoc), can we remove these?
* For TestRMAuditLogger#testFailureLogFormatHelper, let's add the queueName +
partition arguments before the "args" argument. The case with "appId, ...,
queueName, partition" and the "args" case are orthogonal, so it seems best to
order the arguments as such.
* In the same method, let's put the if (queueName != null) and if (partition
!= null) checks before the if (args != null) check
* The added test case
{noformat}
testFailureLogFormatHelper(checkIP, null, null, null, null, null, null,
QUEUE, PARTITION); {noformat}
doesn't seem right to me. We should be adding QUEUE and PARTITION test cases
with testFailureLogFormatHelper calls which have non-null APPID, ATTEMPTID,
etc. arguments, i.e. add a
{noformat}
testFailureLogFormatHelper(checkIP, APPID, ATTEMPTID, CONTAINERID,
new CallerContext.Builder(CALLER_CONTEXT).setSignature(CALLER_SIGNATURE)
.build(), RESOURCE, QUEUE);{noformat}
and
{noformat}
testFailureLogFormatHelper(checkIP, APPID, ATTEMPTID, CONTAINERID,
new CallerContext.Builder(CALLER_CONTEXT).setSignature(CALLER_SIGNATURE)
.build(), RESOURCE, QUEUE, PARTITION); {noformat}
test cases.
> Add submission context label to audit logs
> ------------------------------------------
>
> Key: YARN-9762
> URL: https://issues.apache.org/jira/browse/YARN-9762
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Jonathan Hung
> Assignee: Manoj Kumar
> Priority: Major
> Labels: release-blocker
> Attachments: YARN-9762.01.patch
>
>
> Currently we log NODELABEL in container allocation/release audit logs, we
> should also log NODELABEL of application submission context on app submission.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
