[ 
https://issues.apache.org/jira/browse/YARN-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806939#comment-13806939
 ] 

Vinod Kumar Vavilapalli commented on YARN-1318:
-----------------------------------------------

bq. I think the best way forward is the constructor should only take RMContext 
and everything else should be picked from there. 
That is the correct way. We slowly started moving all services into RMContext 
and avoiding passing services in constructors. You can do that for AdminService 
now, no need to change others - those can be fixed as and when we work on 
patches that affect those services.

bq. To move forward on this, I propose RMContext should be more along the lines 
of a Builder - default constructor (no arguments) and use set* methods to set 
the internal fields.
The current method of passing in whatever is possible in constructor and set 
the remaining using setters when they are ready should continue to work. Why do 
we need to change it? I expect the setters to be minimal, but we can see if we 
need to change it after we are done with all moves instead of changing it all 
now itself.

> Promote AdminService to an Always-On service
> --------------------------------------------
>
>                 Key: YARN-1318
>                 URL: https://issues.apache.org/jira/browse/YARN-1318
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.3.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Blocker
>              Labels: ha
>
> Per discussion in YARN-1068, we want AdminService to handle HA-admin 
> operations in addition to the regular non-HA admin operations. To facilitate 
> this, we need to move AdminService an Always-On service. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to