[
https://issues.apache.org/jira/browse/YARN-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938831#comment-16938831
]
Íñigo Goiri commented on YARN-9859:
-----------------------------------
I would rename the JIRA as Refactor more than cleanup.
A minor comment in OpportunisticContainerAllocatorAMService, we should tune the
indentation for 237 and adding extra indents to the following lines of the
constructor.
For OpportunisticContainerAllocator, we should change the javadoc.
As we are moving DistributedOpportunisticContainerAllocator, would you mind
doing a pass fixing indentation all over that class?
> Code cleanup of OpportunisticContainerAllocator
> -----------------------------------------------
>
> Key: YARN-9859
> URL: https://issues.apache.org/jira/browse/YARN-9859
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-9859.001.patch
>
>
> Right now OpportunisticContainerAllocator is written mainly for Distributed
> Scheduling and schedules Opportunistic containers on limited set of nodes. As
> part of this jira, we are going to make OpportunisticContainerAllocator as an
> abstract class and DistributedOpportunisticContainerAllocator as actual
> implementation. This would be prerequisite for YARN-9697.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
