[
https://issues.apache.org/jira/browse/YARN-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939818#comment-16939818
]
Jonathan Hung commented on YARN-9760:
-------------------------------------
Thanks [~varun_saxena]. Seems fine. A couple nits:
* Do we need to check in
{{hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/resources/capacity-scheduler.xml}}
?
* The YarnConfiguration comment is a bit confusing:
{noformat}
// Configuration for the prefix of the tag which contains workflow ID,
// followed by the prefix. {noformat}
Can we reword this? Maybe "Prefix of an application tag which is followed by
that application's workflow id"
* There's a stray "{{as the user."}} line in the description for
yarn.scheduler.capacity.workflow-priority-mappings (in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/conf/capacity-scheduler.xml)
* Can we make CapacitySchedulerConfiguration#getWorkflowPriorityMappings
return Collection<String> instead? (also getWorkFlowPriorityMappings ->
getWorkflowPriorityMappings)
* Can we push {{if (overrideWithPriorityMappings) {}} in
WorkflowPriorityMappingsManager#getMappedWorkflowPriorityForApp to the top of
this method? That way there's no impact if this feature's not enabled.
* import java.util.HashSet; is unused in MockRM.java
Looks good other than that though.
> Support configuring application priorities on a workflow level
> --------------------------------------------------------------
>
> Key: YARN-9760
> URL: https://issues.apache.org/jira/browse/YARN-9760
> Project: Hadoop YARN
> Issue Type: New Feature
> Reporter: Jonathan Hung
> Assignee: Varun Saxena
> Priority: Major
> Labels: release-blocker
> Attachments: YARN-9760.01.patch, YARN-9760.02.patch
>
>
> Currently priorities are submitted on an application level, but for end users
> it's common to submit workloads to YARN at a workflow level. This jira
> proposes a feature to store workflow id + priority mappings on RM (similar to
> queue mappings). If app is submitted with a certain workflow id (as set in
> application submission context) RM will override this app's priority with the
> one defined in the mapping.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
