[
https://issues.apache.org/jira/browse/YARN-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947628#comment-16947628
]
Szilard Nemeth commented on YARN-8453:
--------------------------------------
Hi [~sunilg]!
Couple of comments:
# Could you rename static field A to QUEUE_A? Similarly with B -> QUEUE_B as
well?
# A_CAPACITY and B_CAPACITY could be private.
# There are some calls to TestUtils.createResource: These can be fit into the
previous line.
# // Register NM1 with 10GB memory, 4 CPU and 0 GPU --> This comment should be
about NM2.
# nm2 variable is not used, please invoke registerNode, but don't assign it to
a variable.
# // Allocate one more containers which doesnt need GPU --> containers should
be singular
# There are 2 occasions where you use Arrays.asList with just one element: You
could use Collections.singletonList() instead.
# Can you extract some common code with
testMaximumAllocationRefreshWithMultipleResourceTypes and your new test method?
Thanks!
> Additional Unit tests to verify queue limit and max-limit with multiple
> resource types
> ---------------------------------------------------------------------------------------
>
> Key: YARN-8453
> URL: https://issues.apache.org/jira/browse/YARN-8453
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
> Affects Versions: 3.0.2
> Reporter: Sunil G
> Assignee: Sunil G
> Priority: Major
> Attachments: YARN-8453.001.patch
>
>
> Post support of additional resource types other then CPU and Memory, it could
> be possible that one such new resource is exhausted its quota on a given
> queue. But other resources such as Memory / CPU is still there beyond its
> guaranteed limit (under max-limit). Adding more units test to ensure we are
> not starving such allocation requests
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
